Update Swift version #6612
Closed
Update Swift version #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
|
msk
pushed a commit
to petabi/pkgsrc
that referenced
this pull request
Aug 30, 2019
According upstream pull request 6612 (<mpv-player/mpv#6612>) and as noticed via PR pkg/54426 newer Xcode (10.2) dropped support for Swift 3 that is used in mpv-0.29.1. Workaround that by disabling swift support. This will probably not needed and should be removed in next stable mpv version.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Xcode (10.2) drops Swift 3 support, so this needed doing.
It also drops the static Swift libs in favor of dynamic; on current macOS (10.14.4), those libs are found at /usr/lib/swift, so this PR uses that, but I'm not sure if that's true on older versions; we might have to add something to ship them in redistributable builds somehow.
Also fixes some deprecation warnings in Obj-C code, and silences all OpenGL deprecation warnings, since they're pretty noisy.